Add escape hatch for mutation convention name formatting#9782
Merged
Conversation
michaelstaib
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an escape hatch for mutation convention name formatting so selected mutation fields can preserve their configured field name when generating convention-based input, payload, and error type names.
Changes:
- Adds a new
DisableMutationReformattingfield flag and publicObjectFieldConfigurationproperty. - Threads the field configuration through mutation type-name formatting and bypasses mutation-name reformatting when the flag is set.
- Adds a test helper and coverage for preserved input/payload names on prefixed mutation fields.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/HotChocolate/Core/src/Types/Types/Descriptors/Configurations/CoreFieldFlags.cs |
Adds the internal flag backing the new escape hatch. |
src/HotChocolate/Core/src/Types/Types/Descriptors/Configurations/ObjectFieldConfiguration.cs |
Exposes the flag as a public field configuration property. |
src/HotChocolate/Core/src/Types.Mutations/MutationConventionTypeInterceptor.cs |
Applies the escape hatch when formatting mutation-derived input, payload, and error type names. |
src/HotChocolate/Core/test/Types.Mutations.Tests/AnnotationBasedMutations.cs |
Adds a prefixed mutation test for preserved input and payload type names. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+878
to
+881
| public string FormatErrorTypeName(ObjectFieldConfiguration mutation) | ||
| => PayloadErrorTypeNamePattern.Replace( | ||
| $"{{{MutationConventionOptionDefaults.MutationName}}}", | ||
| FormatMutationName(mutationName)); | ||
| FormatMutationName(mutation)); |
This was referenced Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.